Re: [PATCH] bfs: prevent underflow in bfs_find_entry()

From: Tigran Aivazian
Date: Mon Mar 09 2020 - 05:14:43 EST


Hello Dan,

On Sat, 7 Mar 2020 at 06:08, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> - int namelen = child->len;
> + unsigned int namelen = child->len;

Thank you, that is sensible, but have you actually verified that
attempting a lookup of a filename longer than 2.2 billion bytes causes
a problem? If that's the case, then your patch should be considered.
If not, it would seem to be a waste of time to worry about something
that cannot ever happen.

Kind regards,
Tigran