Re: [PATCH] drivers: virtio: Make out_del_vqs dependent on BALLOON_COMPACTION

From: David Hildenbrand
Date: Sun Mar 08 2020 - 15:38:41 EST




> Am 06.03.2020 um 11:56 schrieb Vincenzo Frascino <vincenzo.frascino@xxxxxxx>:
>
> ïout_del_vqs label is currently used only when BALLOON_COMPACTION
> configuration option is enabled. Having it disabled triggers the
> following warning at compile time:
>
> drivers/virtio/virtio_balloon.c: In function âvirtballoon_probeâ:
> drivers/virtio/virtio_balloon.c:963:1: warning: label âout_del_vqsâ
> defined but not used [-Wunused-label]
> 963 | out_del_vqs:
> | ^~~~~~~~~~~
>
> Make out_del_vqs dependent on BALLOON_COMPACTION to address the
> issue.
>
> Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
> Cc: Jason Wang <jasowang@xxxxxxxxxx>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

I think this is now the third patch on the list that tries to fix this warning.

Michael, can we finally queue one of these (or is there one in -next already - did not check)?

Thanks