Re: [PATCH] xen: Use evtchn_type_t as a type for event channels

From: Boris Ostrovsky
Date: Fri Mar 06 2020 - 11:08:32 EST




On 3/5/20 4:57 AM, Yan Yankovskyi wrote:
> Make event channel functions pass event channel port using
> evtchn_port_t type. It eliminates signed <-> unsigned conversion.
> Also rename 'evtchn' variables to 'port' in case if 'port' is not
> ambiguous.


> @@ -171,10 +171,10 @@ static int xen_irq_info_common_setup(struct irq_info *info,
>
> info->type = type;
> info->irq = irq;
> - info->evtchn = evtchn;
> + info->evtchn = port;

Hmm... I am not sure these kinds of changes make it much better.


-boris