Re: [PATCH 06/10] perf report: Add 'cgroup' sort key

From: Jiri Olsa
Date: Fri Mar 06 2020 - 09:10:26 EST


On Mon, Feb 24, 2020 at 01:37:45PM +0900, Namhyung Kim wrote:

SNIP

> @@ -634,6 +637,39 @@ struct sort_entry sort_cgroup_id = {
> .se_width_idx = HISTC_CGROUP_ID,
> };
>
> +/* --sort cgroup */
> +
> +static int64_t
> +sort__cgroup_cmp(struct hist_entry *left, struct hist_entry *right)
> +{
> + return right->cgroup - left->cgroup;
> +}
> +
> +static int hist_entry__cgroup_snprintf(struct hist_entry *he,
> + char *bf, size_t size,
> + unsigned int width __maybe_unused)
> +{
> + const char *cgrp_name = "N/A";
> +
> + if (he->cgroup) {
> + struct cgroup *cgrp = cgroup__find(he->ms.maps->machine->env,

eveything is connected :)) great that this one works

jirka