Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq()

From: Thomas Bogendoerfer
Date: Fri Mar 06 2020 - 07:48:19 EST


On Thu, Mar 05, 2020 at 05:27:53PM +0530, afzal mohammed wrote:
> request_irq() is preferred over setup_irq(). Invocations of setup_irq()
> occur after memory allocators are ready.
>
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
>
> Hence replace setup_irq() by request_irq().
>
> remove_irq() has been replaced by free_irq() as well.
>
> There were build error's during previous version, couple of which was
> reported by kbuild test robot <lkp@xxxxxxxxx> of which one was reported
> by Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> as well. There were a
> few more issues including build errors, those also have been fixed.
>
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@xxxxxxxxx>

thank you, applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]