Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD

[Geert Uytterhoeven]

Hi Chunyan,

On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@xxxxxxxxx> wrote:
> From: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx>
>
> Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s,
> since we want them can be built-in when ARCH_SPRD is set as 'm'.

Why would you want a serial driver for a specific platform to be builtin,
while all other platform support is modular?

> Signed-off-by: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx>
> ---
>  drivers/tty/serial/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 52eaac21ff9f..2b9addc0afb5 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135
>
>  config SERIAL_SPRD
>         tristate "Support for Spreadtrum serial"
> -       depends on ARCH_SPRD
>         select SERIAL_CORE
>         help
>           This enables the driver for the Spreadtrum's serial.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds