Re: [PATCH] regulator: pwm: Don't warn on probe deferral

From: Mark Brown
Date: Fri Mar 06 2020 - 07:35:34 EST


On Fri, Mar 06, 2020 at 08:51:29AM +0100, Uwe Kleine-König wrote:

> I wonder if we should do something like:

> ret = some_call(some, args);
> if (ret) {
> if (emit_errmsg_for_err(ret))
> dev_err(dev, "some_call failed: %pE\n", ERR_PTR(ret));
> return ret;
> }

> and have emit_errmsg_for_err return true if ret != -EPROBE_DEFER or some
> kernel parameter is given.

There was some effort in the past to have a dev_probe_err() or something
which could have a similar implementation but that didn't end up going
anywhere I think. I do prefer the debug level log since it's much
easier to have the information there without having to ask for it, that
design would've supported that.

Attachment: signature.asc
Description: PGP signature