Re: [PATCH] KVM: VMX: Use wrapper macro ~RMODE_GUEST_OWNED_EFLAGS_BITS directly

From: Vitaly Kuznetsov
Date: Fri Mar 06 2020 - 04:45:00 EST


Paolo Bonzini <pbonzini@xxxxxxxxxx> writes:

> On 06/03/20 03:17, linmiaohe wrote:
>> Define a macro RMODE_HOST_OWNED_EFLAGS_BITS for (X86_EFLAGS_IOPL |
>> X86_EFLAGS_VM) as suggested by Vitaly seems a good way to fix this ?
>> Thanks.
>
> No, what if a host-owned flag was zero? I'd just leave it as is.
>

I'm not saying my suggestion was a good idea but honestly I'm failing to
wrap my head around this. The suggested 'RMODE_HOST_OWNED_EFLAGS_BITS'
would just be a define for (X86_EFLAGS_IOPL | X86_EFLAGS_VM) so
technically the patch would just be nop, no?

--
Vitaly