Re: [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro

From: Johan Jonker
Date: Fri Mar 06 2020 - 02:22:13 EST


Hi,

Missing #address-cells, #size-cells
Can you still fix that?

On 3/6/20 1:23 AM, Heiko Stuebner wrote:
> Am Mittwoch, 4. MÃrz 2020, 22:30:23 CET schrieb Tobias Schramm:
>> This commit adds initial dt support for the rk3399 based Pinebook Pro.
>>
>> Signed-off-by: Tobias Schramm <t.schramm@xxxxxxxxxxx>
>
> applied for 5.7
>
> Thanks
> Heiko
>
>

> +&edp {
> + force-hpd;
> + pinctrl-names = "default";
> + pinctrl-0 = <&edp_hpd>;
> + status = "okay";
> +
> + ports {

#address-cells = <1>;
#size-cells = <0>;

Don't forget that extra empty line here.


> + edp_out: port@1 {
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + edp_out_panel: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&panel_in_edp>;
> + };
> + };
> + };
> +};