Re: [PATCH] Input: i8042 - Fix the selftest retry logic

From: Dmitry Torokhov
Date: Thu Mar 05 2020 - 23:16:48 EST


Hi AceLan,

On Thu, Mar 05, 2020 at 02:44:23PM +0800, AceLan Kao wrote:
> It returns -NODEV at the first selftest timeout, so the retry logic
> doesn't work. Move the return outside of the while loop to make it real
> retry 5 times before returns -ENODEV.

The retry logic here was for the controller not returning the expected
selftest value, not the controller refusing to communicate at all.

Could you pease tell me what device requires this change?

Thanks.

--
Dmitry