Re: [PATCH v2] uacce: unmap remaining mmapping from user space

From: Herbert Xu
Date: Thu Mar 05 2020 - 20:51:54 EST


On Wed, Feb 26, 2020 at 03:12:06PM +0800, Zhangfei Gao wrote:
> When uacce parent device module is removed, user app may
> still keep the mmaped area, which can be accessed unsafely.
> When rmmod, Parent device driver will call uacce_remove,
> which unmap all remaining mapping from user space for safety.
> VM_FAULT_SIGBUS is also reported to user space accordingly.
>
> Suggested-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
> ---
> v2: Unmap before put_queue, where memory is freed, commented from Zaibo.
>
> drivers/misc/uacce/uacce.c | 16 ++++++++++++++++
> include/linux/uacce.h | 2 ++
> 2 files changed, 18 insertions(+)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt