RE: [PATCH] pinctrl: falcon: fix syntax error

From: Langer, Thomas
Date: Thu Mar 05 2020 - 14:11:46 EST




> -----Original Message-----
> From: linux-gpio-owner@xxxxxxxxxxxxxxx <linux-gpio-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Mathias Kresin
> Sent: Donnerstag, 5. MÃrz 2020 19:23
> To: linus.walleij@xxxxxxxxxx
> Cc: linux-gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> stable@xxxxxxxxxxxxxxx
> Subject: [PATCH] pinctrl: falcon: fix syntax error
>
> Add the missing semicolon after of_node_put to get the file compiled.
>
> Fixes: f17d2f54d36d ("pinctrl: falcon: Add of_node_put() before
> return")
> Cc: stable@xxxxxxxxxxxxxxx # v5.4+
> Signed-off-by: Mathias Kresin <dev@xxxxxxxxx>

Acked-by: Thomas Langer <thomas.langer@xxxxxxxxx>

> ---
> drivers/pinctrl/pinctrl-falcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-falcon.c
> b/drivers/pinctrl/pinctrl-falcon.c
> index a454f57c264e..62c02b969327 100644
> --- a/drivers/pinctrl/pinctrl-falcon.c
> +++ b/drivers/pinctrl/pinctrl-falcon.c
> @@ -451,7 +451,7 @@ static int pinctrl_falcon_probe(struct
> platform_device *pdev)
> falcon_info.clk[*bank] = clk_get(&ppdev->dev, NULL);
> if (IS_ERR(falcon_info.clk[*bank])) {
> dev_err(&ppdev->dev, "failed to get clock\n");
> - of_node_put(np)
> + of_node_put(np);
> return PTR_ERR(falcon_info.clk[*bank]);
> }
> falcon_info.membase[*bank] = devm_ioremap_resource(&pdev-
> >dev,
> --
> 2.17.1