Re: [PATCH v3 0/4] Add QMP V3 USB3 PHY support for SC7180

From: Matthias Kaehlcke
Date: Thu Mar 05 2020 - 13:57:14 EST


Hi Sandeep,

this series has a few minor outstanding comments that prevent it from
landing. Do you plan to respin it soon?

Thanks

Matthias

On Wed, Feb 12, 2020 at 04:51:24PM +0530, Sandeep Maheswaram wrote:
> Add QMP V3 USB3 PHY entries for SC7180 in phy driver and
> device tree bindings.
>
> changes in v3:
> *Addressed Rob's comments in yaml file.
> *Sepearated the SC7180 support in yaml patch.
> *corrected the phy reset entries in device tree.
>
> changes in v2:
> *Remove global phy reset in QMP phy.
> *Convert QMP phy bindings to yaml.
>
> Sandeep Maheswaram (4):
> dt-bindings: phy: qcom,qmp: Convert QMP phy bindings to yaml
> dt-bindings: phy: qcom,qmp: Add support for SC7180
> phy: qcom-qmp: Add QMP V3 USB3 PHY support for SC7180
> arm64: dts: qcom: sc7180: Correct qmp phy reset entries
>
> .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 287 +++++++++++++++++++++
> .../devicetree/bindings/phy/qcom-qmp-phy.txt | 227 ----------------
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 +-
> drivers/phy/qualcomm/phy-qcom-qmp.c | 38 +++
> 4 files changed, 327 insertions(+), 229 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> delete mode 100644 Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>