Re: [PATCH 1/2] bootconfig: Support O=<builddir> option

From: Randy Dunlap
Date: Thu Mar 05 2020 - 13:51:27 EST


On 3/4/20 11:41 PM, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Thu, Mar 5, 2020 at 5:53 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>> On 3/4/20 7:17 PM, Steven Rostedt wrote:
>>> On Wed, 4 Mar 2020 15:04:43 -0800
>>> Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>>>
>>>> On 3/3/20 3:24 AM, Masami Hiramatsu wrote:
>>>>> Support O=<builddir> option to build bootconfig tool in
>>>>> the other directory. As same as other tools, if you specify
>>>>> O=<builddir>, bootconfig command is build under <builddir>.
>>>>
>>>> Hm. If I use
>>>> $ make O=~/tmp -C tools/bootconfig
>>>>
>>>> that works: it builds bootconfig in ~/tmp.
>>>>
>>>> OTOH, if I sit at the top of the kernel source tree
>>>> and I enter
>>>> $ mkdir builddir
>>>> $ make O=builddir -C tools/bootconfig
>>>>
>>>> I get this:
>>>> make: Entering directory '/home/rdunlap/lnx/next/linux-next-20200304/tools/bootconfig'
>>>> ../scripts/Makefile.include:4: *** O=builddir does not exist. Stop.
>>>> make: Leaving directory '/home/rdunlap/lnx/next/linux-next-20200304/tools/bootconfig'
>>>>
>>>> so it looks like tools/scripts/Makefile.include doesn't handle this case correctly
>>>> (which is how I do all of my builds).
>>>>
>>>
>>> Do you build perf that way?
>>
>> No. It should also be fixed.
>
> There are lots of issues when (cross)building the tools and selftest with O=.
> I tried to fix some of them a while ago, but I lost interest.
> https://lore.kernel.org/lkml/20190114135144.26096-1-geert+renesas@xxxxxxxxx/
>
> The only thing you can rely on when (cross)building with O=, is the kernel
> itself ;-)

Yeah, oh well. I'm not ready to just give up on it though.

thanks.

--
~Randy