Re: [PATCH] ethernet:broadcom:bcm63xx_enet:remove redundant variable definitions

From: Florian Fainelli
Date: Thu Mar 05 2020 - 12:27:55 EST


On 3/5/20 4:22 AM, tangbin wrote:
> in this function,âretâ is always assigned,so this's definition
> 'ret = 0' make no sense.
>
> Signed-off-by: tangbin <tangbin@xxxxxxxxxxxxxxxxxxxx>

This looks fine, but your subject should be:

bcm63xx_enet: Remove redundant variable definitions

to matchthe majority of commit subjects done to that file. With that:

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian