Re: [PATCH v2] mm: Make mem_cgroup_id_get_many() __maybe_unused

From: Johannes Weiner
Date: Thu Mar 05 2020 - 12:22:59 EST


On Thu, Mar 05, 2020 at 04:43:54PM +0000, Vincenzo Frascino wrote:
> mem_cgroup_id_get_many() is currently used only when MMU or MEMCG_SWAP
> configuration options are enabled. Having them disabled triggers the
> following warning at compile time:
>
> linux/mm/memcontrol.c:4797:13: warning: âmem_cgroup_id_get_manyâ defined
> but not used [-Wunused-function]
> static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned
> int n)
>
> Make mem_cgroup_id_get_many() __maybe_unused to address the issue.
>
> Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxxxx>
> Cc: Vladimir Davydov <vdavydov.dev@xxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Thanks Vincenzo.