Re: [PATCH] dra7: sata: Fix SATA with CONFIG_ARM_LPAE enabled

[Roger Quadros]

+Nishanth

Robin,

On 05/03/2020 18:04, Robin Murphy wrote:
> On 04/03/2020 9:00 am, Roger Quadros wrote:
> > Even though the TRM says that SATA IP has 36 address bits
> > wired in the SoC, we see bus errors whenever any address
> > greater than 32-bit is given to the controller.
>
> Actually, is it really just SATA? I pulled up a couple of DRA7xx TRMs out of curiosity - thanks for having such easy-to-access documentation by the way :) - and they both give me a clear impression that the entire L3_MAIN interconnect is limited to 32-bit addresses and thus pretty much all the DMA masters should only be able to touch the lower 2GB of DRAM. Especially the bit that explicitly says "This is a high address range (Q8 â Q15) that requires an address greater than 32 bits. This space is visible only for the MPU Subsystem."

You are right that L3 interconnect can only access first 2GB of DRAM.
Which means we should add the bus_dma_limit to the entire L3 bus
instead of just SATA?

> Is it in fact the case that the SATA driver happens to be the only one to set a >32-bit DMA mask on your system?

This looks like the case. Other device drivers might not be overriding
dma_mask at all thus using the default 32-bit dma_mask.

cheers,
-roger

> Robin.
>
> > This happens on dra7-EVM with 4G of RAM with CONFIG_ARM_LPAE=y.
> >
> > As a workaround we limit the DMA address range to 32-bits
> > for SATA.
> >
> > Cc: Christoph Hellwig <hch@xxxxxx>
> > Cc: Robin Murphy <robin.murphy@xxxxxxx>
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > Reported-by: Yan Liu <yan-liu@xxxxxx>
> > Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> > ---
> >
> > NOTE: Currently ARM dma-mapping code doesn't account for devices
> > bus_dma_limit. This is fixed in [1].
> >
> > [1] https://lkml.org/lkml/2020/2/18/712
> >
> > Â arch/arm/boot/dts/dra7.dtsi | 25 ++++++++++++++++---------
> > Â 1 file changed, 16 insertions(+), 9 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> > index d78b684e7fca..895462c22d1c 100644
> > --- a/arch/arm/boot/dts/dra7.dtsi
> > +++ b/arch/arm/boot/dts/dra7.dtsi
> > @@ -642,15 +642,22 @@
> > ÂÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂÂÂÂÂ /* OCP2SCP3 */
> > -ÂÂÂÂÂÂÂ sata: sata@4a141100 {
> > -ÂÂÂÂÂÂÂÂÂÂÂ compatible = "snps,dwc-ahci";
> > -ÂÂÂÂÂÂÂÂÂÂÂ reg = <0x4a140000 0x1100>, <0x4a141100 0x7>;
> > -ÂÂÂÂÂÂÂÂÂÂÂ interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
> > -ÂÂÂÂÂÂÂÂÂÂÂ phys = <&sata_phy>;
> > -ÂÂÂÂÂÂÂÂÂÂÂ phy-names = "sata-phy";
> > -ÂÂÂÂÂÂÂÂÂÂÂ clocks = <&l3init_clkctrl DRA7_L3INIT_SATA_CLKCTRL 8>;
> > -ÂÂÂÂÂÂÂÂÂÂÂ ti,hwmods = "sata";
> > -ÂÂÂÂÂÂÂÂÂÂÂ ports-implemented = <0x1>;
> > +ÂÂÂÂÂÂÂ sata_aux_bus {
> > +ÂÂÂÂÂÂÂÂÂÂÂ #address-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ #size-cells = <2>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "simple-bus";
> > +ÂÂÂÂÂÂÂÂÂÂÂ ranges = <0x0 0x4a140000 0x0 0x1200>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ dma-ranges = <0x0 0x0 0x1 0x00000000>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ sata: sata@4a141100 {
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ compatible = "snps,dwc-ahci";
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ reg = <0x0 0x0 0x1100>, <0x1100 0x0 0x7>;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ phys = <&sata_phy>;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ phy-names = "sata-phy";
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ clocks = <&l3init_clkctrl DRA7_L3INIT_SATA_CLKCTRL 8>;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ ti,hwmods = "sata";
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ ports-implemented = <0x1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂÂÂÂÂ /* OCP2SCP1 */

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki