Re: [PATCH 2/2] KVM: x86: VMX: untangle VMXON revision_id setting when using eVMCS

From: Paolo Bonzini
Date: Thu Mar 05 2020 - 11:43:54 EST


On 05/03/20 17:34, Vitaly Kuznetsov wrote:
>> I'd strongly prefer to keep the alloc_vmcs_cpu() name and call the new enum
>> "vmcs_type". The discrepancy could be resolved by a comment above the
>> VMXON_REGION usage, e.g.
>>
>> /* The VMXON region is really just a special type of VMCS. */
>> vmcs = alloc_vmcs_cpu(VMXON_REGION, cpu, GFP_KERNEL);
> I have no strong opinion (but honestly I don't really know what VMXON
> region is being used for), Paolo already said 'queued' but I think I'll
> send v2 with the suggested changes (including patch prefixes :-)

Yes, please do.

Paolo