RE: [kbuild-all] Re: [PATCH v1 1/1] sched/fair: do not preempt current task if it is going to call schedule()

From: Li, Philip
Date: Thu Mar 05 2020 - 10:14:36 EST


> Subject: [kbuild-all] Re: [PATCH v1 1/1] sched/fair: do not preempt current task if
> it is going to call schedule()
>
> Hi,
>
> Thank you for the patch! Yet something to improve:
Sorry, there're a few duplicated reports around this patch, kindly
ignore similar reports, we will look for the possible issue.

Thanks

>
> [auto build test ERROR on tip/sched/core]
> [also build test ERROR on arm64/for-next/core tip/auto-latest linus/master v5.6-
> rc4 next-20200305]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url: https://github.com/0day-ci/linux/commits/cl-rock-chips-
> com/wait_task_inactive-spend-too-much-time-on-system-startup/20200305-
> 201639
> base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> a0f03b617c3b2644d3d47bf7d9e60aed01bd5b10
> config: s390-zfcpdump_defconfig (attached as .config)
> compiler: s390-linux-gcc (GCC) 7.5.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-
> tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.5.0 make.cross ARCH=s390
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/kvm_host.h:12:0,
> from arch/s390/kernel/asm-offsets.c:11:
> include/linux/sched.h: In function 'set_tsk_going_to_sched':
> >> include/linux/sched.h:1776:27: error: 'TIF_GOING_TO_SCHED' undeclared
> (first use in this function); did you mean 'TIF_SINGLE_STEP'?
> set_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED);
> ^~~~~~~~~~~~~~~~~~
> TIF_SINGLE_STEP
> include/linux/sched.h:1776:27: note: each undeclared identifier is reported only
> once for each function it appears in
> include/linux/sched.h: In function 'clear_tsk_going_to_sched':
> include/linux/sched.h:1781:29: error: 'TIF_GOING_TO_SCHED' undeclared (first
> use in this function); did you mean 'TIF_SINGLE_STEP'?
> clear_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED);
> ^~~~~~~~~~~~~~~~~~
> TIF_SINGLE_STEP
> In file included from include/linux/kernel.h:11:0,
> from include/linux/list.h:9,
> from include/linux/preempt.h:11,
> from include/linux/hardirq.h:5,
> from include/linux/kvm_host.h:7,
> from arch/s390/kernel/asm-offsets.c:11:
> include/linux/sched.h: In function 'test_tsk_going_to_sched':
> include/linux/sched.h:1786:44: error: 'TIF_GOING_TO_SCHED' undeclared (first
> use in this function); did you mean 'TIF_SINGLE_STEP'?
> return unlikely(test_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED));
> ^
> include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
> # define unlikely(x) __builtin_expect(!!(x), 0)
> ^
> make[2]: *** [scripts/Makefile.build:101: arch/s390/kernel/asm-offsets.s] Error 1
> make[2]: Target '__build' not remade because of errors.
> make[1]: *** [Makefile:1112: prepare0] Error 2
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [Makefile:179: sub-make] Error 2
> 142 real 47 user 83 sys 92.07% cpu make prepare
>
> vim +1776 include/linux/sched.h
>
> 1773
> 1774 static inline void set_tsk_going_to_sched(struct task_struct *tsk)
> 1775 {
> > 1776 set_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED);
> 1777 }
> 1778
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx