Re: [PATCH bpf-next v3 01/12] bpf: sockmap: only check ULP for TCP sockets

[Jakub Sitnicki]

On Wed, Mar 04, 2020 at 11:13 AM CET, Lorenz Bauer wrote:
> The sock map code checks that a socket does not have an active upper
> layer protocol before inserting it into the map. This requires casting
> via inet_csk, which isn't valid for UDP sockets.
>
> Guard checks for ULP by checking inet_sk(sk)->is_icsk first.
>
> Signed-off-by: Lorenz Bauer <lmb@xxxxxxxxxxxxxx>
> ---

Reviewed-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>

[...]