Re: [PATCH] ASoc: amd: acp3x: Add missing include <linux/io.h>

[Agrawal, Akshu]

On 3/4/2020 2:10 PM, YueHaibing wrote:
> gcc 7.4.0 build fails:
>
> In file included from sound/soc/amd/acp3x-rt5682-max9836.c:20:0:
> sound/soc/amd/raven/acp3x.h: In function rv_readl:
> sound/soc/amd/raven/acp3x.h:113:9: error: implicit declaration of function readl; did you mean rv_readl? [-Werror=implicit-function-declaration]
>    return readl(base_addr - ACP3x_PHY_BASE_ADDRESS);
>           ^~~~~
>           rv_readl
> sound/soc/amd/raven/acp3x.h: In function rv_writel:
> sound/soc/amd/raven/acp3x.h:118:2: error: implicit declaration of function writel; did you mean rv_writel? [-Werror=implicit-function-declaration]
>    writel(val, base_addr - ACP3x_PHY_BASE_ADDRESS);
>    ^~~~~~
>    rv_writel
We don't hit this error and neither with i386-allyesconfig. Would be 
interesting to know with which config do you get this error.
> Add <linux/io.h> to fix this.

Since readl and writel are used by acp3x.h, it would be better to 
include linux/io.h in acp3x.h and avoid including it in every file which 
includes acp3x.h

Thanks,

Akshu