Re: [PATCH v6 1/3] intel_acpi: Rename drm_dev local variable to dev

From: Jani Nikula
Date: Thu Mar 05 2020 - 04:15:04 EST


On Wed, 04 Mar 2020, Rajat Jain <rajatja@xxxxxxxxxx> wrote:
> Change the struct drm_device * local variable from drm_dev to dev
> per the feedback received here:
> https://lkml.org/lkml/2020/1/24/1143
>
> Signed-off-by: Rajat Jain <rajatja@xxxxxxxxxx>

Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

> ---
> v6: Initial patch (v6 to match other patches in the set)
>
> drivers/gpu/drm/i915/display/intel_acpi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index e21fb14d5e07b..3e6831cca4ac1 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -224,13 +224,13 @@ static u32 acpi_display_type(struct intel_connector *connector)
>
> void intel_acpi_device_id_update(struct drm_i915_private *dev_priv)
> {
> - struct drm_device *drm_dev = &dev_priv->drm;
> + struct drm_device *dev = &dev_priv->drm;
> struct intel_connector *connector;
> struct drm_connector_list_iter conn_iter;
> u8 display_index[16] = {};
>
> /* Populate the ACPI IDs for all connectors for a given drm_device */
> - drm_connector_list_iter_begin(drm_dev, &conn_iter);
> + drm_connector_list_iter_begin(dev, &conn_iter);
> for_each_intel_connector_iter(connector, &conn_iter) {
> u32 device_id, type;

--
Jani Nikula, Intel Open Source Graphics Center