Re: [PATCH 1/1] arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node

From: Bjorn Andersson
Date: Thu Mar 05 2020 - 00:19:33 EST


On Wed 04 Mar 04:23 PST 2020, Rajeshwari wrote:

> To enable kernel critical shutdown feature added critical trip point to

s/added/add/
s/point/points/

> all non CPU sensors to perform shutdown in orderly manner.
>
> Signed-off-by: Rajeshwari <rkambl@xxxxxxxxxxxxxx>
> ---

No need to provide a cover-letter for a single patch.

> arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 78 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index b8a72cf..7e5f14f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1956,6 +1956,12 @@
> hysteresis = <2000>;
> type = "hot";
> };
> +
> + aoss0_crit: aoss0_crit {
> + temperature = <110000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };

The indentation of all but the initial line is off. Same with below
hunks as well. Please correct this.

Regards,
Bjorn