Re: [PATCH 2/4] selftests: Fix seccomp to support relocatable build (O=objdir)

[Shuah Khan]

On 3/4/20 3:42 PM, Kees Cook wrote:
> On Wed, Mar 04, 2020 at 03:13:33PM -0700, Shuah Khan wrote:
> > Fix seccomp relocatable builds. This is a simple fix to use the
> > right lib.mk variable TEST_GEN_PROGS for objects to leverage
> > lib.mk common framework for relocatable builds.
> >
> > Signed-off-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> > ---
> >   tools/testing/selftests/seccomp/Makefile | 16 +++-------------
> >   1 file changed, 3 insertions(+), 13 deletions(-)
> >
> > diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
> > index 1760b3e39730..a8a9717fc1be 100644
> > --- a/tools/testing/selftests/seccomp/Makefile
> > +++ b/tools/testing/selftests/seccomp/Makefile
> > @@ -1,17 +1,7 @@
> >   # SPDX-License-Identifier: GPL-2.0
> > -all:
> > -
> > -include ../lib.mk
> > -
> > -.PHONY: all clean
> > -
> > -BINARIES := seccomp_bpf seccomp_benchmark
> >   CFLAGS += -Wl,-no-as-needed -Wall
> > +LDFLAGS += -lpthread
> >   
> > -seccomp_bpf: seccomp_bpf.c ../kselftest_harness.h
>
> How is the ../kselftest_harness.h dependency detected in the resulting
> build rules?
>
> Otherwise, looks good.

Didn't see any problems. I will look into adding the dependency.

thanks,
-- Shuah