Re: [PATCH 2/2] include/bitmap.h: add new functions to documentation

From: Dennis Zhou
Date: Wed Mar 04 2020 - 15:40:43 EST


Hi Wolfram,

On Wed, Mar 04, 2020 at 03:09:20PM +0100, Wolfram Sang wrote:
> I found these functions only by chance although I was looking exactly
> for something like them. So, add them to the list of functions to make
> them more visible.
>
> Fixes: e837dfde15a4 ("bitmap: genericize percpu bitmap region iterators")
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Cc: Dennis Zhou <dennis@xxxxxxxxxx>
> ---
> include/linux/bitmap.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index 804600f7dc35..71ba0ffaa22a 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -51,6 +51,12 @@
> * bitmap_clear(dst, pos, nbits) Clear specified bit area
> * bitmap_find_next_zero_area(buf, len, pos, n, mask) Find bit free area
> * bitmap_find_next_zero_area_off(buf, len, pos, n, mask, mask_off) as above
> + * bitmap_next_clear_region(map, &start, &end, nbits) Find next cleared region
> + * bitmap_next_set_region(map, &start, &end, nbits) Find next set region
> + * bitmap_for_each_clear_region(map, rs, re, start, end)
> + * Iterate over all cleared regions
> + * bitmap_for_each_set_region(map, rs, re, start, end)
> + * Iterate over all set regions
> * bitmap_shift_right(dst, src, n, nbits) *dst = *src >> n
> * bitmap_shift_left(dst, src, n, nbits) *dst = *src << n
> * bitmap_cut(dst, src, first, n, nbits) Cut n bits from first, copy rest
> --
> 2.20.1
>

Ah thanks. That was a miss not adding the documentation. I can pick
these up unless Andrew would rather run them through his tree. I have a
few other miscellaneous documentation cleanups for percpu I need to run
anyway.

Acked-by: Dennis Zhou <dennis@xxxxxxxxxx>

Thanks,
Dennis