Re: [PATCH] x86/unwind/orc: Do not skip the first frame unless explicitly asked for

From: Josh Poimboeuf
Date: Wed Mar 04 2020 - 12:47:58 EST


On Wed, Mar 04, 2020 at 01:32:59PM +0100, Miroslav Benes wrote:
> ORC unwinder can currently skip the first frame even if a user does not
> ask for it. If both regs and first_frame parameters of unwind_start()
> are set to NULL, state->sp and first_frame are later initialized to the
> same value for an inactive task. Given there is "less than or equal to"
> comparison used at the end of __unwind_start() for skipping stack frames,
> the first frame is always skipped in this case.
>
> Drop the equal part of the comparison and make it equivalent to the
> frame pointer unwinder.
>
> Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>

Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

--
Josh