Re: [PATCH v3 21/27] powerpc/powernv/pmem: Add an IOCTL to request controller health & perf data

[Frederic Barrat]

Le 28/02/2020 Ã 07:12, Andrew Donnellan a ÃcritÂ:
> On 21/2/20 2:27 pm, Alastair D'Silva wrote:
> > From: Alastair D'Silva <alastair@xxxxxxxxxxx>
> >
> > When health & performance data is requested from the controller,
> > it responds with an error log containing the requested information.
> >
> > This patch allows the request to me issued via an IOCTL.
>
> A better explanation would be good - this IOCTL triggers a request to 
> the controller to collect controller health/perf data, and the 
> controller will later respond with an error log that can be picked up 
> via the error log IOCTL that you've defined earlier.

And even more precisely (to also check my understanding):

> this IOCTL triggers a request to
> the controller to collect controller health/perf data, and the
> controller will later respond

by raising an interrupt to let the user app know that

> an error log that can be picked up
> via the error log IOCTL that you've defined earlier.


The rest of the patch looks ok to me.

  Fred