Re: [PATCH v9 04/20] mm/thp: move lru_add_page_tail func to huge_memory.c

From: Kirill A. Shutemov
Date: Wed Mar 04 2020 - 02:47:24 EST


On Mon, Mar 02, 2020 at 07:00:14PM +0800, Alex Shi wrote:
> The func is only used in huge_memory.c, defining it in other file with a
> CONFIG_TRANSPARENT_HUGEPAGE macro restrict just looks weird.
>
> Let's move it close user.

I don't think it's strong enough justification. I would rather keep all
lru helpers in one place.

--
Kirill A. Shutemov