Re: [PATCH bpf-next v2 2/7] bpf: JIT helpers for fmod_ret progs

[Andrii Nakryiko]

On Tue, Mar 3, 2020 at 5:56 PM KP Singh <kpsingh@xxxxxxxxxxxx> wrote:
>
> From: KP Singh <kpsingh@xxxxxxxxxx>
>
> * Split the invoke_bpf program to prepare for special handling of
>   fmod_ret programs introduced in a subsequent patch.
> * Move the definition of emit_cond_near_jump and emit_nops as they are
>   needed for fmod_ret.
> * Refactor branch target alignment into its own function
>   align16_branch_target.
>
> Signed-off-by: KP Singh <kpsingh@xxxxxxxxxx>
> ---

I trust invoke_bpf_prog logic didn't change, code was just moved around, right?

Acked-by: Andrii Nakryiko <andriin@xxxxxx>


>  arch/x86/net/bpf_jit_comp.c | 148 +++++++++++++++++++++---------------
>  1 file changed, 85 insertions(+), 63 deletions(-)
>

[...]