Re: [PATCH 0/5] Simplify /proc/$pid/maps implementation

From: Alexey Dobriyan
Date: Tue Mar 03 2020 - 14:56:58 EST


On Sat, Feb 29, 2020 at 08:59:05AM -0800, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
>
> Back in 2005, we merged a patch from Akamai that sped up /proc/$pid/maps
> by using f_version to stash the user virtual address that we'd just
> displayed. That wasn't necessary; we can just use the private *ppos for
> the same purpose. There have also been some other odd choices made over
> the years that use the seq_file infrastructure in some non-idiomatic ways.
>
> Tested by using 'dd' with various different 'bs=' parameters to check that
> calling ->start, ->stop and ->next at various offsets work as expected.

/proc part looks OK, I only ask to include this description into first
patch, so it doesn't get lost. Often 0/N patch is the most interesting
part of a series.