Re: [PATCHv3 2/2] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE

From: Dmitry Safonov
Date: Tue Mar 03 2020 - 13:07:06 EST




On 3/3/20 4:31 AM, kbuild test robot wrote:
> Hi Dmitry,
[..]

> New smatch warnings:
> drivers/tty/serial/serial_core.c:3123 uart_try_toggle_sysrq() warn: unsigned '++port->sysrq_seq' is never less than zero.

False-positive as just a few lines above:
: if (ARRAY_SIZE(sysrq_toggle_seq) <= 1)
: return false;

I hope it's fine just to ignore this rather than complicate anyhow code
to suppress the warning.

Thanks,
Dmitry