RE: [PATCH bpf-next v2 3/9] bpf: sockmap: move generic sockmap hooks from BPF TCP

From: John Fastabend
Date: Tue Mar 03 2020 - 12:52:48 EST


Lorenz Bauer wrote:
> The close, unhash and clone handlers from TCP sockmap are actually generic,
> and can be reused by UDP sockmap. Move the helpers into the sockmap code
> base and expose them. This requires tcp_bpf_(re)init and tcp_bpf_clone to
> be conditional on BPF_STREAM_PARSER.
>
> Signed-off-by: Lorenz Bauer <lmb@xxxxxxxxxxxxxx>
> ---
> include/linux/bpf.h | 4 ++-
> include/linux/skmsg.h | 28 ----------------
> include/net/tcp.h | 15 +++++----
> net/core/sock_map.c | 77 +++++++++++++++++++++++++++++++++++++++++--
> net/ipv4/tcp_bpf.c | 59 ++++-----------------------------
> 5 files changed, 92 insertions(+), 91 deletions(-)

No changes just moving code around it seems.

Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>