Re: linux-next: Tree for Mar 2 (pinctrl/sprd/pinctrl-sprd.c)

From: Linus Walleij
Date: Tue Mar 03 2020 - 07:45:03 EST


On Mon, Mar 2, 2020 at 5:36 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> On 3/1/20 11:25 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20200228:
> >
>
> on i386 or x86_64:
>
> kconfig warnings and build error:
>
> WARNING: unmet direct dependencies detected for PINCTRL_SPRD
> Depends on [n]: PINCTRL [=y] && OF [=n] && (ARCH_SPRD || COMPILE_TEST [=y])
> Selected by [m]:
> - PINCTRL_SPRD_SC9860 [=m] && PINCTRL [=y]
>
> ../drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map':
> ../drivers/pinctrl/sprd/pinctrl-sprd.c:282:8: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Werror=implicit-function-declaration]
> ret = pinconf_generic_parse_dt_config(np, pctldev, &configs,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> pinconf_generic_dump_config

Should be fixed with

depends on OF=y

in drivers/pinctrl/sprd/Kconfig

Baolin are you onto it?

Yours,
Linus Walleij