Re: [PATCH v1] net: phy: tja11xx: add TJA1102 support

[Marc Kleine-Budde]

On 3/3/20 1:18 PM, Marek Vasut wrote:
> On 3/3/20 8:37 AM, Oleksij Rempel wrote:
>> TJA1102 is an dual T1 PHY chip. Both PHYs are separately addressable.
>> PHY 0 can be identified by PHY ID. PHY 1 has no PHY ID and can be
>> configured in device tree by setting compatible =
>> "ethernet-phy-id0180.dc81".
>>
>> PHY 1 has less suported registers and functionality. For current driver
>> it will affect only the HWMON support.
> 
> Can't you do some magic with match_phy_device (like in
> 8b95599c55ed24b36cf44a4720067cfe67edbcb4) to discern the second half of
> the PHY ?

Great, that looks better.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |