Re: [PATCH] mm/vmscan.c: Clean code by removing unnecessary assignment

[David Hildenbrand]

On 29.02.20 22:40, mateusznosek0@xxxxxxxxx wrote:
> From: Mateusz Nosek <mateusznosek0@xxxxxxxxx>
> 
> Previously 0 was assigned to variable 'lruvec_size',
> but the variable was never read later.
> So the assignment can be removed.
> 
> Signed-off-by: Mateusz Nosek <mateusznosek0@xxxxxxxxx>
> ---
>  mm/vmscan.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index f14c8c6069a6..a605ff36f126 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2427,10 +2427,8 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
>  		case SCAN_FILE:
>  		case SCAN_ANON:
>  			/* Scan one type exclusively */
> -			if ((scan_balance == SCAN_FILE) != file) {
> -				lruvec_size = 0;
> +			if ((scan_balance == SCAN_FILE) != file)
>  				scan = 0;
> -			}
>  			break;
>  		default:
>  			/* Look ma, no brain */
> 

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

-- 
Thanks,

David / dhildenb