Re: [PATCH v2 2/2] mm/gup/writeback: add callbacks for inaccessible pages

[David Hildenbrand]

> Your style earlier in the patch was easier on the reader, why not stay consistent
> with that (and with this file, which tends also to do this), so:
> 
> 		if (flags & FOLL_PIN) {
> 			ret = arch_make_page_accessible(page);
> 			if (ret) {
> 				unpin_user_page(page);
> 				goto pte_unmap;
> 			}
> 		}
> 

+1

-- 
Thanks,

David / dhildenb