Re: [RFC PATCH v3 5/8] regulator: use linear_ranges helper

From: Vaittinen, Matti
Date: Tue Mar 03 2020 - 03:04:17 EST


Hello Mark,

On Tue, 2020-02-25 at 15:33 +0000, Mark Brown wrote:
> On Tue, Feb 25, 2020 at 06:23:31AM +0000, Vaittinen, Matti wrote:
>
> > Only change required on individual regulator drivers should be
> > renaming
> > the struct regulator_linear_range to linear_range. Rest of the
> > changes
> > should be internal to regulator framework, right?
>
> Right, it's that type replacement that should be done atomically.

Yes. And the type replacement is done only in this patch where the
struct is removed from regulator driver.h header - and the linear_range
header providing this new struct is included. Previous patch did not
change the type - just renamed the struct.

Anyways, I did compile test the patch v4 for these commits and there
were no problems in regulator drivers. The BD70528 charger driver had
an issue as the linear_range struct was dublicated there - but this
should be fixed by the v4 where I added one extra patch doing renaming
for this BD70528 charger internal structure.

Best Regards
Matti Vaittinen