Re: [PATCH] ubifs: Don't discard nodes in recovery when ecc err detected

[Zhihao Cheng]

å 2020/3/3 5:14, Richard Weinberger åé:
> On Mon, Mar 2, 2020 at 4:58 AM Zhihao Cheng <chengzhihao1@xxxxxxxxxx> wrote:
> > I mean, the uncorrectable ECC error is caused by hardware which may lead
> > to corrupted nodes detected in UBIFS. I found uncorretable ECC errors on
> > my NAND, in the environment of high temperature and humidity.
> >
> > At present, UBIFS ignores all EBADMSG errors, so the corrupted node is
> > only considered in being caused by unfinished writing. I think UBIFS
> > should consider the corrupted area caused by ECC errors in process
> > ubifs_recover_leb(). no_more_nodes() will skip a read-write unit. Maybe
> > the corrupted area is skipped.
> Well, if your NAND data is corrupted by your environment UBIFS cannot
> do much. Sure, we can paper over some places but at the end of the day
> you will always lose.
>
> What if the UBI VID header becomes unreadable or the root node of the
> index tree?
Agree, thanks for reminding.