Re: [PATCH v3] Documentation: bootconfig: Update boot configuration documentation

From: Randy Dunlap
Date: Mon Mar 02 2020 - 20:52:40 EST


On 3/2/20 12:03 AM, Masami Hiramatsu wrote:
> Update boot configuration documentation.
>
> - Not using "config" abbreviation but configuration or description.
> - Rewrite descriptions of node and its maxinum number.
> - Add a section of use cases of boot configuration.
> - Move how to use bootconfig to earlier section.
> - Fix some typos, indents and format mistakes.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> ---
> Changes in v3:
> - Specify that comments also count in size.
> - Fix a confusing sentence.
> - Add O=<builddir> to make command.


Hi Masami-san,

I think that you misunderstood me. I am asking that you
make "make O=builddir -C tools/bootconfig" work properly, i.e.,
the bootconfig binary should be built in the <builddir>.

Presently when I enter that command, the bootconfig binary
is still built in the kernel source tree.

> Changes in v2:
> - Fixes additional typos (Thanks Markus and Randy!)
> - Change a section title to "Tree Structured Key".
> ---
> Documentation/admin-guide/bootconfig.rst | 181 +++++++++++++++++++-----------
> Documentation/trace/boottime-trace.rst | 2
> 2 files changed, 117 insertions(+), 66 deletions(-)
>


All of the other changes look good to me.

thanks.
--
~Randy
Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>