Re: [PATCH v3] of: overlay: log the error cause on resolver failure

From: Rob Herring
Date: Mon Mar 02 2020 - 12:31:48 EST


On Fri, 28 Feb 2020 09:40:27 +0100, Luca Ceresoli wrote:
> When a DT overlay has a node label that is not present in the live
> devicetree symbols table, this error is printed:
>
> OF: resolver: overlay phandle fixup failed: -22
> create_overlay: Failed to create overlay (err=-22)
>
> which does not help much in finding the node label that caused the problem
> and fix the overlay source.
>
> Add an error message with the name of the node label that caused the
> error. The new output is:
>
> OF: resolver: node label 'gpio9' not found in live devicetree symbols table
> OF: resolver: overlay phandle fixup failed: -22
> create_overlay: Failed to create overlay (err=-22)
>
> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
>
> ---
>
> Changed in v3:
> - add only the message from v1, but as reworded by Frank
>
> Changed in v2:
> - add a message for each error path that does not have one yet
> ---
> drivers/of/resolver.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>

Applied, thanks.

Rob