Re: [PATCH RESEND] dt-bindings: power: Fix dt_binding_check error

From: Jianxin Pan
Date: Mon Mar 02 2020 - 10:57:43 EST



Hi Kevin,


On 2020/3/1 0:28, Kevin Hilman wrote:
> Hi Jianxin,
>
> Jianxin Pan <jianxin.pan@xxxxxxxxxxx> writes:
>
>> Missing ';' in the end of secure-monitor example node.
>>
>> Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings")
>
> Thanks for the fix, but where did this commit ID come from? I think
> this is the right upstream commit:
>
> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
>
> Also, when you resend, can you cc soc@xxxxxxxxxxx The soc maintainers
> are who queue my amlogic tree. I will ack and they can submit to Linus
> for v5.7 so Stephen doesn't have to carry his local linux-next fix
> anymore.
>
> Thanks,
The commit id is not correct, it from my local branch.
I corrected it and added soc maintainers to the cc list.
Thanks for your time.
>
> Kevin
>
>> Reported-by: Rob Herring <robh+dt@xxxxxxxxxx>
>> Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx>
>> Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
>> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> index af32209..bc4e037 100644
>> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> @@ -36,5 +36,5 @@ examples:
>> compatible = "amlogic,meson-a1-pwrc";
>> #power-domain-cells = <1>;
>> };
>> - }
>> + };
>>
>> --
>> 2.7.4
>
> .
>