Re: [PATCH v1 01/11] ACPI: NUMA: export pxm_to_node
From: David Hildenbrand
Date: Mon Mar 02 2020 - 09:09:27 EST
On 02.03.20 15:03, Michal Hocko wrote:
> On Mon 02-03-20 14:49:31, David Hildenbrand wrote:
>> Will be needed by virtio-mem to identify the node from a pxm.
>
> No objection to export the symbol. But it is almost always better to add
> the export in the patch that actually uses it. The intention is much
> more clear that way.
Yeah, but I guess this way people might take more likely a look as if
this would be squashed into a
5 files changed, 1786 insertions(+)
patch. At least that's what my experience tells me :)
If there are hard feelings, I can squash (but I am afraid it will be
even harder to get ACKs/RBs for core-mm changes that way ...)
Thanks for having a look!
--
Thanks,
David / dhildenb