Re: [PATCH] ASoc: amd: Add DMIC switch capability to machine driver

From: kbuild test robot
Date: Mon Mar 02 2020 - 09:00:02 EST


Hi Akshu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on asoc/for-next]
[also build test WARNING on next-20200228]
[cannot apply to v5.6-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Akshu-Agrawal/ASoc-amd-Add-DMIC-switch-capability-to-machine-driver/20200302-170007
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

In file included from include/linux/device.h:15:0,
from include/sound/core.h:10,
from sound/soc//amd/acp3x-rt5682-max9836.c:7:
sound/soc//amd/acp3x-rt5682-max9836.c: In function 'acp3x_probe':
>> sound/soc//amd/acp3x-rt5682-max9836.c:341:23: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
dev_err(&pdev->dev, "DMIC gpio failed err=%d\n",
^
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
>> sound/soc//amd/acp3x-rt5682-max9836.c:341:3: note: in expansion of macro 'dev_err'
dev_err(&pdev->dev, "DMIC gpio failed err=%d\n",
^~~~~~~

vim +/dev_err +341 sound/soc//amd/acp3x-rt5682-max9836.c

323
324 static int acp3x_probe(struct platform_device *pdev)
325 {
326 int ret;
327 struct snd_soc_card *card;
328 struct acp3x_platform_info *machine;
329
330 machine = devm_kzalloc(&pdev->dev, sizeof(*machine), GFP_KERNEL);
331 if (!machine)
332 return -ENOMEM;
333
334 card = &acp3x_card;
335 acp3x_card.dev = &pdev->dev;
336 platform_set_drvdata(pdev, card);
337 snd_soc_card_set_drvdata(card, machine);
338
339 dmic_sel = devm_gpiod_get(&pdev->dev, "dmic", GPIOD_OUT_LOW);
340 if (IS_ERR(dmic_sel)) {
> 341 dev_err(&pdev->dev, "DMIC gpio failed err=%d\n",
342 PTR_ERR(dmic_sel));
343 return PTR_ERR(dmic_sel);
344 }
345
346 ret = devm_snd_soc_register_card(&pdev->dev, &acp3x_card);
347 if (ret) {
348 dev_err(&pdev->dev,
349 "devm_snd_soc_register_card(%s) failed: %d\n",
350 acp3x_card.name, ret);
351 return ret;
352 }
353 return 0;
354 }
355

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip