Re: [PATCH 1/2] pty: define and set show_fdinfo only if procfs is enabled

From: Greg Kroah-Hartman
Date: Mon Mar 02 2020 - 05:51:58 EST


On Mon, Mar 02, 2020 at 11:49:53AM +0100, Tobias Klauser wrote:
> Follow the pattern used with other *_show_fdinfo functions and only
> define and use pty_show_fdinfo if CONFIG_PROC_FS is set.

if proc_fs is not set, it will not be used anyway, right?

I'd rather keep #ifdef out of the .c files than add this. How much
memory does it save, and are you using a system without procfs that
needs this savings?

thanks,

greg k-h