Re: [PATCH v4 06/11] drm/meson: venc: make drm_display_mode const

From: Laurent Pinchart
Date: Mon Mar 02 2020 - 04:59:29 EST


Hi Neil,

Thank you for the patch.

On Thu, Feb 06, 2020 at 08:18:29PM +0100, Neil Armstrong wrote:
> Before switching to bridge funcs, make sure drm_display_mode is passed
> as const to the venc functions.
>
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> drivers/gpu/drm/meson/meson_venc.c | 2 +-
> drivers/gpu/drm/meson/meson_venc.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 4efd7864d5bf..a9ab78970bfe 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -946,7 +946,7 @@ bool meson_venc_hdmi_venc_repeat(int vic)
> EXPORT_SYMBOL_GPL(meson_venc_hdmi_venc_repeat);
>
> void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
> - struct drm_display_mode *mode)
> + const struct drm_display_mode *mode)
> {
> union meson_hdmi_venc_mode *vmode = NULL;
> union meson_hdmi_venc_mode vmode_dmt;
> diff --git a/drivers/gpu/drm/meson/meson_venc.h b/drivers/gpu/drm/meson/meson_venc.h
> index 576768bdd08d..1abdcbdf51c0 100644
> --- a/drivers/gpu/drm/meson/meson_venc.h
> +++ b/drivers/gpu/drm/meson/meson_venc.h
> @@ -60,7 +60,7 @@ extern struct meson_cvbs_enci_mode meson_cvbs_enci_ntsc;
> void meson_venci_cvbs_mode_set(struct meson_drm *priv,
> struct meson_cvbs_enci_mode *mode);
> void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
> - struct drm_display_mode *mode);
> + const struct drm_display_mode *mode);
> unsigned int meson_venci_get_field(struct meson_drm *priv);
>
> void meson_venc_enable_vsync(struct meson_drm *priv);

--
Regards,

Laurent Pinchart