Re: [PATCH] mm/shmem.c: Clean code by removing unnecessary assignment

[Pankaj Gupta]

> From: Mateusz Nosek <mateusznosek0@xxxxxxxxx>
>
> Previously 0 was assigned to variable 'error'
> but the variable was never read before reassignemnt later.
> So the assignment can be removed.
>
> Signed-off-by: Mateusz Nosek <mateusznosek0@xxxxxxxxx>
> ---
>  mm/shmem.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 31b4bcc95f17..84eb14f5509c 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -3116,12 +3116,9 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
>
>         error = security_inode_init_security(inode, dir, &dentry->d_name,
>                                              shmem_initxattrs, NULL);
> -       if (error) {
> -               if (error != -EOPNOTSUPP) {
> -                       iput(inode);
> -                       return error;
> -               }
> -               error = 0;
> +       if (error && error != -EOPNOTSUPP) {
> +               iput(inode);
> +               return error;
>         }
>
>         inode->i_size = len-1;
> --
> 2.17.1

Acked-by : Pankaj Gupta <pankaj.gupta.linux@xxxxxxxxx>

>
>