RE: [PATCH V2] thermal: imx_thermal: Use __maybe_unused instead of CONFIG_PM_SLEEP

From: Anson Huang
Date: Mon Mar 02 2020 - 03:26:21 EST


Hi, Uwe


> Subject: Re: [PATCH V2] thermal: imx_thermal: Use __maybe_unused instead
> of CONFIG_PM_SLEEP
>
> On Mon, Mar 02, 2020 at 03:50:10PM +0800, Anson Huang wrote:
> > Use __maybe_unused for power management related functions instead of
> > #if CONFIG_PM_SLEEP to simplify the code.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > Reviewed-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> IMHO translating my "otherwise looks fine" in a "Reviewed-by" is a bit bold.
> Please don't assume this.

OK, will keep it in mind next time, thanks.

Anson