Re: [PATCH] powerpc/fsl_booke: avoid creating duplicate tlb1 entry

From: Scott Wood
Date: Sat Feb 29 2020 - 18:09:42 EST


On Thu, 2020-01-23 at 11:19 +0000, Laurentiu Tudor wrote:
> In the current implementation, the call to loadcam_multi() is wrapped
> between switch_to_as1() and restore_to_as0() calls so, when it tries
> to create its own temporary AS=1 TLB1 entry, it ends up duplicating the
> existing one created by switch_to_as1(). Add a check to skip creating
> the temporary entry if already running in AS=1.
>
> Fixes: d9e1831a4202 ("powerpc/85xx: Load all early TLB entries at once")
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> ---
> arch/powerpc/mm/nohash/tlb_low.S | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)

Assuming you've tested this on all combinations of 32/64 relocatable and not:

Acked-by: Scott Wood <oss@xxxxxxxxxxxx>

-Scott