Re: [PATCH V3 03/13] kprobes: Add symbols for kprobe insn pages

From: Arnaldo Carvalho de Melo
Date: Fri Feb 28 2020 - 13:51:54 EST


Em Fri, Feb 28, 2020 at 06:20:04PM +0100, Jiri Olsa escreveu:
> On Fri, Feb 28, 2020 at 11:36:00PM +0900, Masami Hiramatsu wrote:
> > On Fri, 28 Feb 2020 15:51:15 +0200
> > Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
> > > # perf probe __schedule
> > > Added new event:
> > > probe:__schedule (on __schedule)
> > > # cat /proc/kallsyms | grep '\[kprobe\]'
> > > ffffffffc0035000 t kprobe_insn_page [kprobe]
> > > ffffffffc0054000 t kprobe_optinsn_page [kprobe]

> > Could you make the module name as [kprobes] ?
> > BTW, it seems to pretend to be a module, but is there no concern of
> > confusing users? Shouldn't it be [*kprobes] so that it is non-exist
> > module name?

> note we already have bpf symbols as [bpf] module

That bracket-wrapped convention by now is not module related, but
instead non-main-kernel :-) If one wants to enumerate the modules in the
system, then use /proc/modules, then, to get the symbols for it, look at
symbols in /proc/kallsyms in that [ start, start + module size ] range
and strip whatever comes after '[' :-)

- Arnaldo