Re: [PATCH] exec: remove comparision of variable i_size of type loff_t against SIZE_MAX

From: Al Viro
Date: Thu Feb 27 2020 - 18:40:58 EST


On Thu, Feb 27, 2020 at 03:31:33PM -0800, Scott Branden wrote:
> Remove comparision of (i_size > SIZE_MAX).
> i_size is of type loff_t and can not be great than SIZE_MAX (~(size_t)0).

include/linux/types.h:46:typedef __kernel_loff_t loff_t;
include/uapi/asm-generic/posix_types.h:88:typedef long long __kernel_loff_t;

And boxen with size_t smaller than long long do exist. Anything
32bit will qualify. Pick any such and check that yourself...